Template:ListingEdit

Hi Verdy, your changes on Template:Listing seem to have broken the template. The edit button below listings disappeared like 4-5 days ago.--Renek78 (talk) 21:03, 6 July 2017 (UTC)

I have not removed any edit link, I was only concerned on adding the support for BiDi text (and I was asked to do that in a public discussion).
If there was some "edit" button, I don't know where it was, and it was probably removed before.
And I don't see what is missing really: pagers are still editable as well as sections. And I still see another link to add another place using a template wizard.
Can you be more precise, and give an example of an affected page ? Verdy p (talk) 21:13, 6 July 2017 (UTC)
Every listing, which had been created with the add listing functionality had a link to edit this entry at the bottom (of that listing). If one clicked there he/she came back to the template form to update the listing. The button was right next to the Wikipedia/Wikidata symbol and the information, when this listing has been updated the last time. It's surprising, that nobody mentioned this until now. Wikivoyage doesn't seem to be that popular yet.--Renek78 (talk) 21:23, 6 July 2017 (UTC)
It looks there's some hidden "black magic" in the javascript that adds such tool, possibly it looks for too precise HTML element types to detect where it should insert that edit link, using some broken CSS selector to locate them in the DOM of the generated HTML.
I'm looking to it now. But I'm curious too see where is the code that insert such edit links for each "Listing" item, it probably has another bug there, and anyway this behavior was not documented anywhere and so it was untestable... Verdy p (talk) 21:27, 6 July 2017 (UTC)
Not sure whether this helps you but I found one entry, which still has the Edit button. It is listing number 4 in Amsterdam/Zuid#Museums--Renek78 (talk) 21:39, 6 July 2017 (UTC)
Sorry for spamming you, but I found out, that listings with the "| lastedit=xxx" tag have the edit button, the others do not.--Renek78 (talk) 21:51, 6 July 2017 (UTC)
OK this should be fixed now (and I have documented this blackmagic case in the template code). This is effectively a problem with the way it was designed with external javascript performing unsafe handling (where it would have been much better to insert an **explicit** mark in the HTML to indicate where to insert the edit link). Verdy p (talk) 22:15, 6 July 2017 (UTC)
Great! Thanks very much for your dedication!--Renek78 (talk) 06:03, 7 July 2017 (UTC)