User talk:Wrh2/Archive 2015

Active discussions

Please leave new comments at User talk:Wrh2. For talk page archives from other years see:

Thank youEdit

Hi Wrh2, thanks for making me an autopatroller! :) There is so much to do on Wikivoyage. Gizza (t)(c) 00:24, 3 January 2015 (UTC)

Another Thank YouEdit

I just wanted to thank you for starting the discussion to allow me to post directly. I will continue to contribute here responsibly. VerbInteractive (talk) 18:46, 6 January 2015 (UTC)

Regarding the mobile view of the Hebvoy main pageEdit

Hi Ryan. In continuation to our conversation in the Travellers' pub... although I am currently the only active admin on Hebvoy.... since I am not an expert with all that have to do with wiki coding... (only a few of us are) I would be happy if you could assist me in finding what piece of code exactly I must add or remove for the Hebvoy main page so that it would be displayed properly in mobile devices. Alternatively, if you are incapable of helping me fix this bug, please refer me to an expert that would be able to help me fix this annoying bug. ויקיג'אנקי (talk) 21:19, 15 January 2015 (UTC)

I'm having trouble reading the Hebrew, but if you look at Template:Mapbanner on the English site, you'll see at the top the code:
<div id="mainpage-map" class="js-proportonal-resize nomobile">
The "nomobile" means that everything inside of that div won't appear in a mobile browser. If you look further down, you'll see:
<div class="mf-mobile-only" id="mf-mapbanner">
The "mf-mobile-only" means that section will only appear for mobile browsers. I would assume that the corresponding templates on the Hebrew site will contain similar sections, so changing the "mf-mobile-only" section should allow you to resolve your issues. -- Ryan • (talk) • 21:51, 15 January 2015 (UTC)
Thanks for the help. I will try changing this in the next hour. ויקיג'אנקי (talk) 13:10, 16 January 2015 (UTC)

Edits with AWBEdit

Hi Ryan, I noticed in this edit to Auckland that where the edit abbreviated a street name, a double space was entered, eg, "6 Mills  Ln"; "Vincent  St". It doesn't display, of course, and it seems pedantic to mention it, but since the same edit removed trailing spaces from lines, perhaps it is not too pedantic. Cheers. Nurg (talk) 07:13, 19 January 2015 (UTC)

Thanks - I'm working on some updates to the existing Wikivoyage AWB scripts and missed that mistake. It should be fixed in future runs. Please let me know if you see any other issues. -- Ryan • (talk) • 07:21, 19 January 2015 (UTC)
Thanks. In the same edit, a number of things were moved from "address" fields to "directions". The first example is "corner Kitchener and Wellesley Sts" for Auckland Art Gallery. This is in fact the address, according to the gallery - http://www.aucklandartgallery.com/visit/location-and-access#Address. The second example is "corner Victoria and Federal St" for Sky Tower. Again, this is the address according to https://www.skycityauckland.co.nz/about-us/contact-us/. Nurg (talk) 07:23, 19 January 2015 (UTC)
I've noticed a lot of listings that use directions instead of a street address, so I added a rule to move any address that starts with "corner of" or "near the" or similar patterns to the "directions" field. That strikes me as the right solution in nearly all cases, although perhaps not for those two particular locations. I can remove the rule if it makes sense to do so, but I think it might be better to just undo the change in the rare cases like the two you cited - Carmel (California) is another odd case where street numbers aren't used, but I think these examples are highly unusual. Does that seem reasonable? -- Ryan • (talk) • 07:35, 19 January 2015 (UTC)

A long weekend in Puerto RicoEdit

If we are doing away with itineraries I think that should be made clear. To a Wikipedian such as myself, the merge tag seemed like one of those "I think it should be this way but I'm not going to state why or start a discussion" tags, which are grossly common on enwiki. Meanwhile at the bottom there's a template stating it is a "usable article", apparently conflicting with the merge tag is meant to imply. If it means anything, you can discount my recent changes, which would then qualify the article for deletion under the "one year" rule. To be frank I didn't get much from the itinerary anyway :) Regards — MusikAnimal talk 02:24, 23 January 2015 (UTC)

It's not that Wikivoyage is doing away with all itineraries, but itineraries such as "A time period in place name" are deprecated since they are 1) arbitrary and 2) specific to the preferences of the person creating them. WV:Itineraries#"Personal" itineraries has more details. I've updated A long weekend in Puerto Rico‎ to include a link to that guideline, and also created Category:Articles to be merged without explanations to track any usage of {{merge}} without an explanation provided. Hopefully I haven't soured you on Wikivoyage - your contributions will be kept, they'll just get merged into another article! -- Ryan • (talk) • 04:51, 23 January 2015 (UTC)

Listings Removed/RevertedEdit

Hi Ryan,

Thanks for starting the discussion. I have noticed the hotel listings I added to this site are being removed. I can give several examples if needed but I am not sure why some listings are staying while others are being removed. We follow the same pattern for each listing so it does not make sense to me that some are added while others are removed. Your recent message states our listing was removed for not following the guidelines. We have read through your guidelines to make sure we follow what is outlined. Further, the site welcomes businesses to add their listing to build up the resource even more.

I work at the Corporate offices so I have a team of individuals that are working to 1) Clean up listings since we've changed URLs to many of our hotels. We have consolidated much of our properties into one site so that is the reason our URLs have changed. 2) Work with individual hotel owners to make sure properties are up-to-date and help them out by offering support in certain areas such as what we are doing here. If you link to an individual hotel owners site then we leave the link as is. If the hotel is not listed on the page, we then move forward adding a listing. This is our process. Any insights into why our listings are being removed would be appreciated. I want to make sure we follow your guidelines. Thank you. —The preceding comment was added by Buash (talkcontribs)

I assume when you say you've "read through your guidelines" that you are referring to the WV:Don't tout guideline that was noted on your user talk page. If so, you'll note that the "nutshell" summary at the top of that page states " If you are a marketer or employed by a business chain you should not add listings for properties operated by that chain to Wikivoyage", and there is an entire section in that guideline devoted to hotel marketers at WV:Don't tout#Marketers and SEOs. I'm not sure if you found something in that discussion unclear, if so you can ask any questions on your user talk page or in the Pub. -- Ryan • (talk) • 19:35, 5 February 2015 (UTC)

Thanks for your response. I will try to be more clear. I am not sure what we are doing to "tout" the business. We include the same information that every other hotel chain on the page has i.e. - Name, location, URL (just one) check in and check out times, contact information, number of rooms etc. We don't include text that is promotional. Now, in terms of hotel marketers, I don't see how my team going in and adding a listing is different than me emailing all of the individual hotel owners asking that they come to this site and add their hotel. Someone will potentially be adding the hotel. We are just trying to compete with the other hotel chains that are listed such as Marriott, Best Western, Hilton and the list goes on. Since travelers visit this page we feel our hotel is just as relevant as others listed. In terms of SEO, the links are nofollow so there is no "SEO" value to us. We are simply trying to get in front of travelers possibly looking for a place to stay in a certain areas just like all the other chains listed on the site are. I will try the Pub page to see if I can get some additional details. Thanks.

Huh?Edit

Hey, Ryan. It's DAZ14LPA. I read the FAQ on the wikivoyage page, but I still don't get it! It doesn't make sense to me, so can you give me some tips? What pictures of PSL would make the best banner if you know the area because it says that you have traveled quite a lot. Help me out, please.

-DAZ14LPA

Please see this comment that Danapit added to your user talk page, which provides some pointers for creating a page banner (specifically, banner guidelines can be found at Wikivoyage:Banner Expedition#Standards). -- Ryan • (talk) • 21:23, 17 February 2015 (UTC)
That didn't help. DAZ14LPA (talk) 21:57, 14 April 2015 (UTC)

Listing editorEdit

Could you provide me few more information about the changes that you have made in February? I would understand if are applicable to it:voy. Let me be more specific. In particular I'm interested in the ones NOT related to "last edit". I'm telling you this because apparently the last bug that I've found over it:voy and that I've highlighted you here seems to work fine, so I don't know if with the last modification has been "unintentionally fixed" :) or if it's because of the it:voy custom code. In the second case, I would appreciate if you could spend some of your spare time on support me on its troubleshooting. Thanks, --Andyrom75 (talk) 09:40, 28 February 2015 (UTC)

I've put together a summary of changes at MediaWiki talk:Gadget-ListingEditor.js#Summary of recent changes. Let me know if that helps! -- Ryan • (talk) • 02:14, 1 March 2015 (UTC)
Thanks Ryan, your list seems to be pretty clear. Now, considering that I'm not importing the lastedit feature, I think that the it:voy "should" be aligned with en:voy, but we suffer the bug that I've mentioned few days ago. Could you support for debug? --Andyrom75 (talk) 12:51, 1 March 2015 (UTC)
In case you would make some tests I've created this page where I've removed some functions used on saving to reduce the area to debug; while this page has a couple of listing usable for the tests. --Andyrom75 (talk) 23:26, 2 March 2015 (UTC)
I've noticed that the problem occurs in the wikiTextToListing function. In particular at var listParams = string.split('|'); because the halfpipe ("|") inside the image, is wrongly considered as a parameter separator of the listing. I don't understand why it occurs only on it:voy. Any idea? --Andyrom75 (talk) 00:42, 3 March 2015 (UTC)
Ok check again. The example that I've created here didin't reproduce the bug. Now it does. Please review it. --Andyrom75 (talk) 00:59, 3 March 2015 (UTC)
I've seen that you have found out that the problem is on the equal sign. Any idea on how to patch this behaviour? --Andyrom75 (talk) 18:53, 4 March 2015 (UTC)
I'll look at this eventually and will let you know, but it's not a high priority for me right now since it's such a specific case. Ideally it would be nice to find an existing Javascript library that parses templates so that we don't have to re-invent that functionality. -- Ryan • (talk) • 19:00, 4 March 2015 (UTC)
It's specific but not so uncommon, because it happens to insert an URL in the content, and the URL may contain the equal sign that could break the mask functionality.
encodeURIComponent() and decodeURIComponent() can be used to encode/decode the equal sign. We should find the right point to apply them. --Andyrom75 (talk) 21:06, 4 March 2015 (UTC)

What do you think about the use of the above functions? --Andyrom75 (talk) 13:36, 10 March 2015 (UTC)

I haven't had a chance to look at the listing editor issues yet, although I'm not sure I understand the proposed encoding/decoding solution - if encoding was done prior to parsing the template then wouldn't the parsing break, since all equals signs would encode? And if it was done prior to saving the parameter value then wouldn't the URLs break, since equals signs would be encoded? Farsi Wikivoyage has made some updates that might be worth reviewing (I haven't had a chance to look at them yet) to see if they address this issue: Wikivoyage talk:Listing editor#Fixes. -- Ryan • (talk) • 15:04, 10 March 2015 (UTC)
No code available for those fixes, however, are related to other bugs.
Coming back to the original topic, you have said that you want pre-existing coding/encoding functions and that's what I've provided you. You should look at the code so see where to insert them properly. --Andyrom75 (talk) 15:50, 12 March 2015 (UTC)
Unfortunately the user is not able to show the changed code for its patch, so I think that you should check them inside his code. However, if you have limited time I would suggest you to think first to the resolution of this bug, because, while in the other two cases the mask won't open or open a wrong listing, in this case the mask will delete the inserted text during the saving phase so it's definitely worse. --Andyrom75 (talk) 09:31, 15 March 2015 (UTC)

Listing editor on fr:voyEdit

Hello,

I tried to introduce the last edit date on the french listing editor. It works relatively fine but I can't find why the edit button after the listing on pages is not appearing. I would be grad if you can have a look and if your can make any small improvement in the presentation it would be appreciate.

Thanks, Adehertogh (talk) 11:54, 28 February 2015 (UTC)

I responded at fr:Discussion utilisateur:Adehertogh#Utilisateur:Adehertogh/common.js. Hope that helps! -- Ryan • (talk) • 02:29, 1 March 2015 (UTC)
Thanks it works!!!--Adehertogh (talk) 15:40, 1 March 2015 (UTC)

before you delete my placesEdit

check in with someone else. a mod i can trust. --Kontukiao2 (talk) 15:39, 9 March 2015 (UTC)

StopEdit

please i will report you to other mods. --Kontukiao2 (talk) 15:46, 9 March 2015 (UTC)

CarouselEdit

Hi:

  • You had moved carousel code from MediaWiki:Common.js and MediaWiki:Common.css to Extension:Gadgets. I probably am the only one that tested carousel with 30 or so images (listings) and it was working correctly until that move... Did you change any code? It's not a big deal as it does not appear elsewhere as far as I know except on the MainPage... Several things that I noticed with multiple items in my testing of carousel now occur:
    1. Page/display not starting at 1st listing (#1) but rather at random listing.
    2. Refreshing a page jumps all over and displays a random or different listing.
Just passing this on - Example: Animals of India - Matroc (talk) 02:22, 10 March 2015 (UTC)
The scrolling to a random starting element was actually intentional per Wikivoyage:Travellers' pub#DotM, page view stats, and a potential problem with (and solution to) the Main Page carousel (Special:Diff/2726541/2729938), although it probably should have been done in a way that was configurable. I have a very long TODO list at the moment and won't have much free time in the coming days, but when I get a chance I'll look into adding a solution where it will only randomize for carousels that use a specific class name. Sorry for the breakage on your local page! -- Ryan • (talk) • 06:06, 10 March 2015 (UTC)
Thanks! It is not a high priority for me as this was only a test page that I made. As I stated before, I am probably the only one on Wikivoyage that did something like this. I just thought you might want to have been made aware of this situation in case it rears its ugly head again down the road. - lol. Never know I might run into you at the Nashua Mall! Cheers! - Matroc (talk) 06:51, 11 March 2015 (UTC)
@Matroc: The carousel should now only scroll to a random element on page load if it has class "jcarousel-randomize". Let me know if you still see any issues. -- Ryan • (talk) • 04:21, 17 March 2015 (UTC)
Hi thanks! - now there is new issue in that the carousel elements are numbered 2-40 and not 1-39 -- the carousel does start on the 1st element (in this case now #2) -- apologize for taking up your valuable time - hopefully a minor adjustment - Matroc (talk) 03:42, 18 March 2015 (UTC)
I have no idea why this would make a difference (perhaps because pagination changed slightly in the new JCarousel 0.3.3), but a slight CSS tweak fixes the problem - Special:Diff/2744746/2749736. -- Ryan • (talk) • 04:49, 18 March 2015 (UTC)
Excellent - looks like it is fixed - great! - many thanks - Matroc (talk) 04:57, 18 March 2015 (UTC)

Edit filterEdit

Ryan. Don't you think we should add edit filter in Special:Tags which would tag edits containing links. This way we can easily reduce promotional material. --Saqib (talk) 19:32, 13 March 2015 (UTC)

Seems fine to me. Maybe start a discussion in the Pub. -- Ryan • (talk) • 23:12, 13 March 2015 (UTC)
Hello Ryan. So far we've no opposition to proposed edit filter so I went ahead and created the filter. The filter working when IP users add URLs but I'm not sure if it work for newly registered accounts. Would appreciate if you please look into it. --Saqib (talk) 19:11, 8 April 2015 (UTC)
For these types of requests it might be better to solicit feedback in the pub so anyone with knowledge of edit filters can help out. I've never created an edit filter, and while I greatly enjoy assisting with the technical development of the site, at the moment my day job is leaving me a bit burned-out and somewhat lacking in desire to spend additional non-work hours reading docs and testing changes. Hope that makes sense - I very much appreciate the effort you put into this filter, and I'm happy to help out with tasks that don't take much brain power on my part, but for the moment I'd rather not take on responsibility for things that I'm unfamiliar with. -- Ryan • (talk) • 04:51, 9 April 2015 (UTC)

Kiparissi LakoniasEdit

March 18, 2015 - Thank you for restoring Kiparissi Lakonias. It is an unusual village (combination of architecture, mountain/coastal lansdcape and isolation) but relatively unknown (even to Greeks). It has a few restaurants and small hotels and is a rambler's and a climber's paradise. Learning how to write correct Wikivoyage articles (including maps, POI, etc) is not so straightforward I would say.--Nature lover (talk) 18:35, 18 March 2015 (UTC)

Wikis are sort of like the Wild West - things get added, changed, deleted, and moved around all the time, but in the end things always seem to work out, so hopefully this incident didn't dissuade you from contributing. I look forward to seeing what you can do with this new article, and thanks for contributing! -- Ryan • (talk) • 18:40, 18 March 2015 (UTC)

Old Wikitravel account recover?Edit

Hi Ryan,

I tried to get help from Evan on his talk page, but later found out that he seem not to be active anymore. Are you able to help with the matter mabye?

Issue is that back in Wikitravel time (and before it was bought by the company) I used to do some edits there (and very few on pl:Wikitravel) under the JanSlupski name. Rigtht now I just got some messages about Wikimedia account merging event and I thought it would be nice if my Wikitravel->Wikivoyage edits/account were merged as well.

Unfortunately Wikivoayage accounts were not on the merge list and after some digging I found out that in here it was renamed to User:(WT-en) JanSlupski. Moreover I cannot login to that account nor recover the password (no email address message or so). Is there any chance to rename this account to just "JanSlupski" and recover the password? I hope I would be able to merge it with "global" JanSlupski account then.

Thanks, and all the best,

Jan 21:16, 18 March 2015 (UTC)

All contributions made on WT were imported for the launch of Wikivoyage and credited as "(WT-en) Username", as you've noted (these "import" accounts are not active accounts that anyone can log into, they exist solely for attribution purposes). The ability to merge those imported contributions to a Wikimedia account was available for nearly two years but has since been disabled - Wikivoyage:User account migration is the page where such requests were formerly made, but the functionality to merge accounts was disabled in October 2014. At this point I honestly don't know what (if any) options are available to you aside from starting fresh - meta:Help:Unified login#Can I merge different usernames? indicates that merging accounts is not supported, although perhaps a steward at meta might have a suggestion (meta:Steward requests), or you can try asking in the Pub to see if someone else has an idea. Sorry I can't be more help, but it's been a few years since the migration to Wikivoyage and most of tools that were created for the launch of Wikivoyage are no longer available. -- Ryan • (talk) • 21:29, 18 March 2015 (UTC)
Thanks a lot for your answer. So let it be as is then, not that important after all. I was just "woken up" by that merging email (I successfully merged account from pl:Vikivoyage, that was probably created after and some other), but as you could note I wasn't active for long time now. --Jan
Please feel free to use your User:JanSlupski global account here; just log in using your usual credentials. I think stewards can merge in your (WT-en) contributions but I wouldn't swear to it. Powers (talk) 20:51, 20 March 2015 (UTC)

Multiline content listingsEdit

Discussion moved to MediaWiki talk:Gadget-ListingEditor.js#Multiline content listings

User:Willy's on his WheelsEdit

Hi, Ryan. Can you please explain the preemptive indef block of this user? He has no contributions or deleted contributions on Wikivoyage, and his name could be merely witty; I don't see any clear proof that the name equates to an incontestable intent to vandalize. What am I missing? Ikan Kekek (talk) 21:17, 6 April 2015 (UTC)

Any account that uses a variation of the name "Willy on Wheels" is an account whose owner plans to perform page move vandalism once the account is no longer too new to be prevented from performing page moves. Google "Willy on Wheels" for more details. -- Ryan • (talk) • 21:39, 6 April 2015 (UTC)
Also note that due to the many, many impersonators, usernames ending with "on wheels" are now globally disallowed by Wikimedia - see the "WoW" subsection of meta:Title blacklist. -- Ryan • (talk) • 21:49, 6 April 2015 (UTC)
Thanks. It's this history that I didn't know about. Ikan Kekek (talk) 22:10, 6 April 2015 (UTC)

Unwarranted Reversions / Misunderstanding policyEdit

Please see my talk page, ErnieNode (talk) 07:56, 14 April 2015 (UTC)

You Don't UnderstandEdit

Wrh2, you don't understand my frustration. I feel like Ikan is always on my back, monitoring my every move. It's scaring me and I feel like...you know. I'm not trying to harass him, but I'm just angry. Help me out. DAZ14LPA (talk) 21:56, 14 April 2015 (UTC)

One last thing, before I forget, I'm sorry I got mad. Forget everything negative I've said about Ikan; I took a look at his work, and I didn't take it lightly when he edited my posts that I got frustrated and blamed him; I sincerely apologize for any and all wrong-doings, and I never meant to say I quit; like I said, I was frustrated and just blamed him like a fool. Had I known that he was an adminstrator, high in the ranks to say, I wouldn't started this whole thing. He may not take the apology, but I'm glad to make the attempt and get it off my chest. If I get deleted, I'll be fine; I deserved it. DAZ14LPA (talk) 19:46, 25 April 2015 (UTC)

I saw you ask me a question on the Treasure Coast talk page; it was taken care of before you even asked me to change it. And you asked me to do it like you thought I was stupid and should be kicked off the site. How come? BTW, you only call someone with an @ on Twitter and other social media, not here, just saying. Donny (talk) 15:03, 12 June 2015 (UTC)
Here's the comment in question - it was made on February 8, and the redirects were restored on February 9. The @ symbol is automatically added in discussions when {{ping}} is used - that is a template that ensures that the "pinged" user will get a wiki message pointing them to the discussion. As to the statement that "you asked me to do it like you thought I was stupid and should be kicked off the site", if that's your takeaway then please re-read my comment as you've read something into it that simply isn't there. -- Ryan • (talk) • 15:31, 12 June 2015 (UTC)
Oh............kay then. :| You also never answered by question about a picture idea for Port St. Lucie. No pictures in Wikimedia Commons and as IK suggested Flickr, no good pictures were found on that site (they are taken in the middle of NOWHERE). All you asked me to do was read the instructions, and that did NOT answer my question at all; if you've been here or not, just tell me, please. Donny (talk) 18:17, 12 June 2015 (UTC)
You still haven't gotten back to me on that question @Wrh2:. Why not? Donny (talk) 22:54, 13 June 2015 (UTC)

Warning to NewbysEdit

Here's a summary of my experience on Wikivoyage. I found Wikivoyage a few weeks ago and thought what a good idea it was. I spent some time in the sandbox and reading various guidelines encouraging me to pitch in, and not to worry about getting things wrong, and telling me about the friendly and helpful community. I then thought about what I could add that would be useful to others, taking care to follow the relevant policies. Since there were a couple of tours that I went on last year that I could thoroughly recommend (because they provided lots of interesting information that was otherwise unavailable) I added them under Carcassonne and [Albi].

I checked back later to see if my edits had registered OK. There were no messages saying thank you for your effort. No message of welcome to the community. Nothing. Not even my edits. It took me some concerted effort to figure out that they had been deleted ("reverted") by Saqib. No explanation. No suggestions. No encouragement. Nothing. So I put the edits back and ask why they had been "reverted". In response they were once again reverted by Saqib. No explanation was given other than a link to Listings#Tour_listings, the policy on Tour listings. This was a bit puzzling because my edits obviously did comply with the policy - 100% as far as I could see. Anyone who knew the two places listed and who looked at what the details of the tours involved would have seen this immediately. On talk, I therefore asked this question "Saqib, Could you please explain why you are reverting my edits, even though they comply with the stated policy, as you will have known if you had followed the link included". But Saqib was clearly too important and too busy to provide a response.

Instead, a response came from Ryan. No welcome. No offer of help. He said that there were two "issues". The first was that "guided tours are generally only considered appropriate when the destination cannot be visited without a guide.". This of course is not true. What the policy says is that Tours can be listed on Wikivoyage as long as they constitute a value-added activity. If a traveller could fulfill the substance of the tour on their own, the tour should not be listed. (my emboldening). As I kept pointing out, my edits complied fully with the stated policy at Listings#Tour_listings, (since they do constitute a value-added activity and a traveller could certainly not fulfill the substance of the tour on their own, even with all available audioguides, guidebooks, and everything else available). Ryan's second "issue", was that "the tours are being added as advertising for a tour operator, which is considered touting and is strongly discouraged...". I looked at touting and found that my edits did not count as "touting" under the policy. I was then, and am now, completely mystified how anyone could read either edit as advertising or touting.

I was so annoyed that I asked how to complain. My assumption was that Saqib and Ryan must be just kids messing about and that a responsible adult would be able to put them right. But no. There is apparently no complaints mechanism, so if a group of kids fail to understand a policy or get some wacky unwarranted idea into their heads, or take a dislike to you, or just decide to back each other up irrespective of the facts, then there is nothing anyone can do about it.

Of course, neither Saqib nor Ryan responded to my key point - that my edits were in line with stated policies. Instead of addressing the points made, Ikan Kekek now joined in and said this

"In any case, it looks to me like you may be ignoring this fundamental part of the tour policy Tours can be listed on Wikivoyage as long as they constitute a value-added activity. If a traveller could fulfill the substance of the tour on their own, the tour should not be listed.

The idea of quoting back to me the fundamental part of the policy that I had myself relied on and emboldened was little short of malign genius. Ikan Kekek then added

"That means, if individual travellers can see these Cathar-related sights without hiring you [sic], you [sic] don't get to list your [sic] tours or your [sic] company. As it further states "In practice this policy disallows listing most[...]guided tours since the substance of such tours can generally be fulfilled by an independent traveller[.]".

I don't need to belabor this, but Ikan Kekek has gone to considerable lengths to ignore the "value added" criterion and the key fact that the substance of these tours cannot be fulfilled by an independent traveller - the whole point of the policy. He is now firmly convinced that I own a tour company. I find it difficult to believe that these are genuine errors.

Normally, if three out of three separate people suggest that I'm in the wrong, then I tend to suspect that they are right. But I have looked pretty carefully at this over the last few days, and there really is no question about it. I don't believe that Saqib, Ryan or Ikan Kekek have understood the policy (which is simple enough), or visited the places concerned, or even bothered to consider what might constitute value added in this case. I might have thought this was just wilful ignorance, except that all three have all gone out of their way to ignore or misconstrue every point I have made, and have then invented a pretty zany excuse to justify their mistake - my "obvious anger" proves that they are right!

So Saqib, Ryan and Ikan Kekek, I have no idea how your minds are working or why you you might want to behave like this. Frankly, I find your behaviour baffling. I'm sure you'll be delighted to learn that I will not be troubling you or Wikivoyage ever again with eccentric ideas about basic courtesy, listing attractions, adding value, complying with policy, or with my "obvious anger" or indeed with anything else.

ErnieNode (talk) 17:31, 22 April 2015 (UTC)

Since the above comment was placed on numerous pages, I'd ask that any responses be made at Wikivoyage talk:Welcome, newcomers#Warning to Newbys rather than here. -- Ryan • (talk) • 17:50, 22 April 2015 (UTC)

MediaWiki:Spam-blacklistEdit

Unsure about this edit: from mw:Extension:SpamBlacklist the extension looks to be looking at URLs and not body text - in which case mw:Extension:AbuseFilter may be the only way to do what you're trying here? K7L (talk) 14:36, 5 May 2015 (UTC)

Thanks for the pointer. Non-URL blacklist patterns worked at one point in the past, but based on edits made today it appears they no longer work. -- Ryan • (talk) • 19:07, 5 May 2015 (UTC)
I'm pretty sure our non-URL blacklist hasn't functioned since we moved to Wikivoyage. Powers (talk) 01:28, 7 May 2015 (UTC)

Bot check for page name with no wikilink?Edit

You asked:

  • Is there a way to ensure that all article text that matches an article name has at least one wikilink in the article?

That might be awkward - the bot could certainly attempt such a task, but there are so many towns with "same name, different province or country" that require disambiguation. The text might mention Portland... that name appears on some town in Oregon but that's not a unique name as that village was named after some town in Maine and there are likely others. Some town names are repeated across so many jurisdictions ("Springfield" in particular) that telly programmes have started using them as the generic Anytown as they could be any of multiple locations. K7L (talk) 03:58, 26 May 2015 (UTC)

It gets even worse than that when you think of usages like "New York style pizza" or even "Joe's New York deli" where a link wouldn't really make sense. It's something that's now on my list of things to think about, but it would need to be a plugin for AWB or something similar that requires manual review since (as you've pointed out) an automated bot would generate too many errors. If something could be done, however, it would be a huge SEO and usability win. -- Ryan • (talk) • 04:03, 26 May 2015 (UTC)
Ah yes, the whole NYC vs. NYS bit. What's a poor bot to do? K7L (talk) 12:04, 26 May 2015 (UTC)
It's worse than that. Consider common words that have destination articles like Bath and Independence and Fucking... Powers (talk) 15:03, 26 May 2015 (UTC)
Great. Is there a restaurant which serves chicken at the marina? K7L (talk) 15:16, 26 May 2015 (UTC)

I am the one contributing infos about Herman Trekker at WikitravelEdit

Hi Ryan, thanks for being concern on attribution and copyrights. I was the one who contributed info about Herman Trekker at Wikitravel. I have climb Mt. Rinjani November 2014, where Herman and his team provided us (German and French-Canadian) a very good trekking service. I am from the Philippines, and in no way have personal link and intention to promote Herman Trekker. Please respect my contribution. Feel free to talk to me for your concerns.

Thanks for fixing my editEdit

I got things a little wrong in the San Jose (Costa Rica) article. Thanks for cleaning up after me. Ikan Kekek (talk) 03:44, 8 June 2015 (UTC)

Sorry for undoing your revert, but that IP seemed to be making mostly-good changes, so I'm guessing the bad characters in the San José (Costa Rica) article were just a browser issue or something like that. -- Ryan • (talk) • 04:28, 8 June 2015 (UTC)
The only issue was my moving the info about the ATMs. Ikan Kekek (talk) 04:35, 8 June 2015 (UTC)

MediaWiki talk:Gadget-ListingEditor.jsEdit

Could you review my last three topics that I've published on the talk in the subject? PS Belive me, I'm sorry for disturbing you all the time, but you are the the only "tech-admin" that I know here on en:voy. --Andyrom75 (talk) 07:04, 22 June 2015 (UTC)

I read through them briefly and will revisit after a deeper review. I thought "vcard" was being used on German Wikivoyage, and some of the heading changes may similarly be in use on other language versions, but I'm not positive. Thanks for continuing to keep us up-to-date on your changes. -- Ryan • (talk) • 13:57, 22 June 2015 (UTC)
'vCard' is the German (and likely Italian) original version of {{listing}} and has existed for several years. They ditched the <tags> ages ago. K7L (talk) 15:32, 22 June 2015 (UTC)
As stated by K7L, vCard are in use only in de:voy where the listing editor is not in use. So regarding this patch and the last one (i.e. nowiki) I'm 100% confident that you can proceed without looking for alternatives. --Andyrom75 (talk) 06:33, 24 June 2015 (UTC)
Please take some time to evaluate the 3 suggested patches. --Andyrom75 (talk) 21:54, 29 June 2015 (UTC)
Sorry, this is my fifth straight week of traveling for work, so I've not had much brainpower remaining for dealing with after-hours wiki code. Go ahead and make the necessary changes if you'd like. I'm concerned about the increasing number of hacks for things like commented listings, multi-line listings, and extra params like "phoneextra" or "wikipedia", and thus have been giving some thought to how the listing editor could be updated to be both more flexible and more robust, but haven't yet come up with a good solution. -- Ryan • (talk) • 22:19, 29 June 2015 (UTC)
Only admin can change Mediawiki pages. If you want I can prepare a Sandbox that you can completely copy and paste. PS Sorry for disturbing you while working, so no problem if you would prefer to wait more time ... my only concern is my memroy, because I tend to forget things that I do not process asap :-P --Andyrom75 (talk) 22:36, 29 June 2015 (UTC)
Definitely don't apologize - I'm sorry for not getting to it sooner. I definitely won't forget, although I sketched out an updated design on the plane and may pursue that over the coming weeks as I think our current implementation is a bit too fragile. -- Ryan • (talk) • 05:56, 30 June 2015 (UTC)
Ok thanks, in this case I'll wait for you. Please ping me when you'll do it, as a personal reminder :-P --Andyrom75 (talk) 06:49, 30 June 2015 (UTC)
@Andyrom75: I implemented your changes last night. -- Ryan • (talk) • 13:32, 30 June 2015 (UTC)
Thank you Ryan. Please consider to add also the nowiki patch. To understand the importance of it, open MediaWiki:Gadget-ListingEditor.js in edit mode, and take a look at the very bottom of the page under "Templates used on this page:". You could see that it's trying to use the following template: "Template:\\s*(" + regex.join" ....clearly it doesn't exist and doesn't make sense....
The list of the missing template (used in at least one article) are stored in Special:WantedTemplates and it goes there without that patch. PS I've just fixed a couple of those templates. --Andyrom75 (talk) 15:32, 30 June 2015 (UTC)
@Andyrom75:   Done - Special:Diff/2818522/2818835. -- Ryan • (talk) • 16:14, 30 June 2015 (UTC)

Delhi Wikvoyage PageEdit

I Rayan I have added the district divisions in Delhi Wikivoyage page, but some of the links are directing to the main Delhi page, can you help. --Rangan Datta Wiki (talk) 16:54, 29 June 2015 (UTC)

@Rangan Datta Wiki: I've deleted the existing redirects, but you might want to solicit feedback at Talk:Delhi prior to creating new district articles. Also, see Talk:Delhi#Districts and some of the other district discussions on that talk page. -- Ryan • (talk) • 17:08, 29 June 2015 (UTC)
Thanks Rayan. I did have a look at Talk:Delhi#Districts and I will definitely discuss it in the talk page before creating separate articles for districts.--Rangan Datta Wiki (talk) 17:16, 29 June 2015 (UTC)

Thanks for clarificationEdit

  • Thank you for clarifying "Articles using legacy listings" -- Matroc (talk) 18:56, 1 July 2015 (UTC)
No problem. I've got a bot that will convert legacy XML listings automatically but I almost never run it anymore since they are always copied from WT. In this case the listing in question was both copied from WT and plastered across four separate articles, so a revert was definitely warranted. -- Ryan • (talk) • 19:06, 1 July 2015 (UTC)

Trawna?Edit

Unsure about this edit... Burj Khalifa is not in North America. K7L (talk) 04:00, 7 July 2015 (UTC)

Thanks, I've corrected it - I missed the "in North America" hiding at the end of a long sentence, and then got distracted trying to chase down the listing editor bug that is preventing correctly editing listings in that "See" section (the editor Javascript thinks {{seeDistricts}} is a listing template). -- Ryan • (talk) • 04:18, 7 July 2015 (UTC)

MediaWiki:Gadget-ListingEditor2.jsEdit

I haven't looked at the code yet (until is WIP), but one quesiton. Is it possible to isolate (and maybe easily removed) the code associated to the last-edit feature? Most of the language version (if not all) do not use it, and personally I don't like as it has been thought and implemented here on en:voy. In it:voy time ago we have discussed about it and we would like to associate it ONLY to the price, the mostly time-dependent parameter, and we would like to keep the current syntax that we are adopting right now (manually entered) price=blabla€ (month year).

This approach is very different by the current one, so if you could also handle a version in this way it would be greatly appreciated, otherwise, if you don't have enough time to develop it would be enough to put us in the condition to disable(/better delete) this feature. --Andyrom75 (talk) 07:16, 9 July 2015 (UTC)

Thanks for the feedback. Before pushing the new version live I'd like to ensure that it is easier to isolate changes that are specific to different language versions and will make sure that the "last edit" date logic can be easily ignored. Ideally I'd like to split the code into a "core" module and one that can be customized to add template-specific and UI-specific functions, but I need to give that some more thought. -- Ryan • (talk) • 14:45, 9 July 2015 (UTC)
Sure, no problem, take your time. Maybe when you think that code is almost done I would share some other enhancement that IMO worth to be implemented. --Andyrom75 (talk) 18:48, 9 July 2015 (UTC)
Sorry for bothering you again. I share my thoughts reading your comment placed at the very beginning of the script.
  1. "Automatically replace newlines in listing content with <p> tags.". This was discussed in the past (I don't recall in which language) and the result was to not use any HTML code, because an average user is not familiar with it. If you like to implement it, please do it in a way that can be easily excluded/suppressed.
  2. "Display the "alt" and "fax" fields only when they have values." being part of the standard set of parameters those should be always visible both in the mask and in the wikicode. On the other hand you can show in the mask all the not standard parameters found in the wikicode; this would be definitely useful to catch typo and "not official" parameters. With "not official" I'm referring to the ones use temporary in a language for testing before they would became a part of the official set of that language (after that, they can have their box inside the mask).
  3. "Change "business closed" to "delete the listing"" We use it in it:voy because closing is not the only reason to remove a listing, and it's good to be used with "Allow viewing and editing the edit summary." that is excellent, is a big miss of the current implementation. Most of the times is important to specify we are making a certain change in the listing and we are forced to change the wikicode instead of using the mask.
PS Have you taken a look of all the listed known bug in the various pages? Just to be sure that your new code will be able to catch and solve them. --Andyrom75 (talk) 18:12, 10 July 2015 (UTC)
Thanks again for the feedback. Some responses:
  1. The <p> is never shown to the user - any <p> tags are replaced by newlines when the listing is shown in the editor, and then converted back to <p> tags when the listing is saved. Use of <p> tags in multi-paragraph listings is the only solution for displaying paragraphs within wiki lists (see your test cases at User:Andyrom75/Sandbox and mw:Help:Lists#Paragraphs in lists) so I think this is the right solution. I can make that behavior configurable if necessary, but I don't think any language version would want listings that break list formatting. You can test it out by enabling the gadget in your preferences (disable the old listing editor gadget first) and then editing test listings at User:Wrh2/Sandbox.
  2. Disabling of any field is configurable in the new code using the "hideDivIfEmpty" option, and I'll make that clearer. The current listing editor on English Wikivoyage already suppresses "fax" by default.
  3. I'll need to solicit more feedback about changing "closed" to "remove" as I think that was contentious in the past, but hopefully including the ability to change the edit summary will alleviate any concerns. Potentially making edit summary a required field when the "remove listing" field is checked would be a sensible update.
As to the known bugs, are you just referring to Wikivoyage:Listing editor#Bugs and feedback and Wikivoyage:Listing editor#Known issues, or is there another list somewhere? Aside from the issues called out in the changelog (like fixing session expiration issues) I wasn't planning on addressing every known issue in the current editor, but I'll definitely make sure that the new version does break anything that works with the current listing editor. -- Ryan • (talk) • 18:39, 10 July 2015 (UTC)
The problem on HTML (i.e. P or BR) is on the wikitext, not in the mask. The best solution (if existing) shouldn't add extra cahracters in the description. If the HTML solution is the only viable one, it must be possibile to be disabled/removed.
I know that in en:voy fax is hidden, but is not a good solution to hide a standard parameter, however it's important that each community can apply the desired behaviour.
I think that summary shouldn't be forced (although it should be pre-filled as it is now), but free as normally is. I can eliminate a listing through wikitext with no summary, and the behavious should be the same.
I don't recall at the moment where the bugs are listed. I've just suggested you to consider their review during your development because maybe now it's easier for you than in the future. --Andyrom75 (talk) 23:11, 10 July 2015 (UTC)
A part the previous comment, I would add few more because I've taken a very quick look at the beginning of the code.
Considering that I would avoid the behaviour "skipIfEmpty" I would split "LISTING_TEMPLATE_PARAMETERS" into "BASE_TEMPLATE_PARAMETERS" and "LISTING_TEMPLATE_PARAMETERS" where the first one do not have "hours" (and neither "checkin/out") that will be added in the second just like "checkin/out" are added into "SLEEP_TEMPLATE_PARAMETERS", so in "SLEEP_TEMPLATE_PARAMETERS" there's no need to specify anything about "hours".
I would also keep the "tips" inside the declaration as in the previous script. From one side, to concentrate at the beginning the text that should be translated (easier to find), and from the other side to implement few basic cycle to build the mask. This would shorten the code. Take into account that the dimension of the code is almost doubled and this code will be loaded in any page, so we should keep an eye also on lean coding not only on readibility where you have done a great job. In this direction maybe the changes on 2.0 & TO DO could be stored at the beginning of the talk page. I've seen few comments in two lines that can be written in just one (tiny save but better than nothing :-)) --Andyrom75 (talk) 07:16, 12 July 2015 (UTC)
A quick response to the concerns about code size - I haven't actually increased the amount of code in the listing editor, although I have greatly increased the amount of documentation about what the existing code is doing. That will have no effect at all on performance since all of the gadget code, including the JS & CSS, is compressed and minified by Mediawiki - comments are stripped out before they are ever sent to the user. See mw:ResourceLoader for more details. -- Ryan • (talk) • 07:44, 12 July 2015 (UTC)
Good point! I've fogotten it. If it's only documentation is fine (I haven't really checked the balance). --Andyrom75 (talk) 18:03, 12 July 2015 (UTC)

────────────────────────────────────────────────────────────────────────────────────────────────────

@Andyrom75: At this point the MediaWiki:Gadget-ListingEditor2.js listing editor code is in a state where I think it is complete, minus any further bug fixes or requested small changes. I've split it into three modules - the ListingEditor.Config module contains all configuration that would need to be customized for a different Wikivoyage language version, the ListingEditor.Callbacks module contains functions that might not be shared between language versions, and the ListingEditor.Core module contains the bulk of the code and should not require any changes for different language versions. There is a significant amount of documentation in the code that explains what should be customized for each language version, and how the customization should be done.

Regarding your suggestions above, each language version would be free to construct the LISTING_TEMPLATE_PARAMETERS arrays in whatever manner was preferred, whether that involves a BASE_TEMPLATE_PARAMETERS array, a SLEEP_TEMPLATE_PARAMETERS array, or some other form. Similarly, the EDITOR_FORM HTML can be split up so that fields to be translated are broken out into separate strings, but for English Wikivoyage I was concerned that doing so would make the code less readable.

The new version fixes several issues in the old code and should (I think) be easier to maintain and to customize for different language versions, but since different languages all have different implementations I'd like to work with you and others to address any concerns. There is no hurry, but when you have time I'd be glad to hear any additional feedback or concerns you might have. -- Ryan • (talk) • 06:56, 24 July 2015 (UTC)

first of all, I want to thank you for the great effort that you have put in this activity. Currently I'm still abroad after the Wikimania event, but I hope in the next few days to give a look at it. I suppose that it would take me some time to implement all the Italian customization and to remove what we don't use, but it be a good exercise to check the desired flexibility. I'll keep you posted, --Andyrom75 (talk) 01:05, 28 July 2015 (UTC)
If you're interested in trying out the new version I can save you some work by putting together a version based on the current Italian listing editor, but I'll need help deploying and testing it once it's ready. I'll be traveling this week and may have time to do the work while flying if this is something that would be useful. -- Ryan • (talk) • 01:12, 28 July 2015 (UTC)
such help would be really appreciated. Basically we need to remove the last edit feature (we need a different implementation, but not necessarily we need to discuss it now) and to add the existing code that is able to properly manage the commented listings as per our models. I'll look for other details afterwards. --Andyrom75 (talk) 17:04, 28 July 2015 (UTC)
Two questions about the Italian listing editor - the "commentedListing" code in the formToText() method, is the purpose of that just to removed commented-out empty listings that (I assume) are added in the article template? Or is it doing something else? Second, the "square bracket" code in wikiTextToListing - is that just trying to work around the bug with equal signs in links that you highlighted at User:Andyrom75/Sandbox#Content field & equal sign or is it doing something else? Does that code work? Aside from those two things I think it should be very easy to use the new code and have the Italian listing editor work the same way as it works currently and I have a mostly-finished conversion on my laptop. -- Ryan • (talk) • 03:55, 29 July 2015 (UTC)
If you look at our city model, you'll see that it has several commented listing, used to provide a clear example to the new editor, on which is the right way to add new information. Once added a "real & filled" listing, the example is useless and can be removed. This is what the JS mask is currently doing. If we add the first listing into a section, the commented listing will be substituted with the new one, otherwise, it will simply add it at the end of the section. In the eat/sleep (i.e. Dove mangiare/dormire) section there's a difference. Considering that there are 3 standard subsections (i.e. Prezzi modici/medi/elevati), the first listing will be automatically positioned in the middle price level, unhiding also its title.
The code in wikiTextToListing has been added, for another reason. When there is a commented listing inside an article (and as you can see, it:voy is full of commented listings) the information shown in the JS mask are wrong, well, are related to another listing. This patch fix this problem. The problem arisen after the implementation of a patch, maybe the patch for the bug that you have mentioned but I don't recall it exactly.
PS Sorry my my temporary absence but in this period I've got a lot things to manage outside Wikivoyage. I'm doing my very best... --Andyrom75 (talk) 08:04, 5 August 2015 (UTC)
I've put a copy of the work-in-progress version for Italian Wikivoyage at User:Wrh2/Gadget-ListingEditor-it.js. It's not something that I can test easily, and if you don't want to use it that's completely understandable. Note that in order for it to work on Italian Wikivoyage you'll need to add a container for the "edit" link to your listing template. Something like the following placed at the end of your template:
<span class="listing-metadata-items"></span>
Let me know if there are any questions, bugs, or functional changes needed. I'll do my best to keep this in sync with MediaWiki:Gadget-ListingEditor.js. -- Ryan • (talk) • 01:58, 19 August 2015 (UTC)

HelloEdit

I will only use this account for wikivoyage and i will not vandalize please believe me Ryan? Give me one more chance after that block me indef. --Gol929 (talk) 23:37, 9 July 2015 (UTC)

IncludeonlyEdit

I saw you put <includeonly> around most of a template (here). Why? Shouldn't that be used only for auto-included categories and other stuff that mustn't end up on the template page?

I think it is quite confusing to end up at an empty template page. At this page there is documentation, but anyway I would prefer to see what the template looks like. Without parameters some templates looks weird, but usually that is a minor problem compared to not seeing the template at all.

--LPfi (talk) 19:43, 11 July 2015 (UTC)

That's pretty standard practice - if you view the template page directly it shows documentation about the template (ideally with an example of the template usage) rather than a broken rendering of the template due to missing params. We've done it with most of our templates, and Wikipedia does the same. -- Ryan • (talk) • 19:56, 11 July 2015 (UTC)
Surprising. I am used to seeing a default version of the template (usually without parameters, sometimes with <noinclude> versions, sometimes example wikicode). I prefer the practice on sv-wp, but I am not going to try to make a change here. (I take your word for practice on en-wp, which I suppose you mean when you say Wikipedia) --LPfi (talk) 21:09, 11 July 2015 (UTC)
It's a relatively recent convention, coming only once use of the documentation subpage became common. I, too, miss seeing the template "raw", so to speak, but proper documentation should obviate that. Powers (talk) 01:19, 12 July 2015 (UTC)
I approve that change because in this case (template with parameters without default values) is right thing to do. Only templates without parameters like Template:Stub (or with standard values) can avoid the use of Includeonly, although is a good practice to have always <includeonly>...template code...</includeonly><noinclude>{{documentation}}</noinclude>, becuase it helps to "remind" lazy developers to write the documentation (99% of developers are lazy when comes the moment to write docs instead of code :-P) and to keep track of them, because using a dedicated category (currently missing in Template:Documentation), can be collected all the templates that do not have their own manual. --Andyrom75 (talk) 07:30, 12 July 2015 (UTC)

Applying Listing Editor to a subset of pages onlyEdit

Hi Ryan! Do you know if it is possible to apply Listing Editor (or any similar gadget) to a subset of pages that are not selected by their namespace but, e.g., by a certain category? The goal is to avoid loading gadget on those pages where it is clearly not needed. We need this for some technical development on Russian Wikivoyage. I would be grateful for your insight. Thanks in advance! --Alexander (talk) 20:16, 5 August 2015 (UTC)

The following code in the listing editor is doing something similar to what you want:
    var namespace = mw.config.get( 'wgNamespaceNumber' );
    if (namespace !== 0 && namespace !== 2 && namespace !== 4) {
        return;
    }
    if ( mw.config.get('wgAction') != 'view' || $('#mw-revision-info').length
            || mw.config.get('wgCurRevisionId') != mw.config.get('wgRevisionId')
            || $('#ca-viewsource').length ) {
        return;
    }
It would be relatively easy to add an additional check that would suppress the listing editor for any page that didn't contain a certain heading, ID, or other value by adding another condition to this section of code. -- Ryan • (talk) • 20:42, 5 August 2015 (UTC)
Thank you, Ryan. We will give it a try. --Alexander (talk) 21:43, 5 August 2015 (UTC)

Edit

Hi Ryan, I noticed that you linked to the draft Wikivoyage:Banners page that I had set up. I was waiting for the new banner template to be released into WV before taking it any further in case there were any relevant changes. I'm sure that you are aware of its status, but just wanted to be clear that it isn't official in any way yet.

I was also hoping for more input from others as well. For the most part it is just minimal guidance gleaned from the exhibition page.

Thanks! --Andrewssi2 (talk) 02:00, 13 August 2015 (UTC)

I apologize if I did something incorrectly, but I'm not seeing any links created by me for Special:WhatLinksHere/Wikivoyage:Banners. Are you sure you've got the right person? -- Ryan • (talk) • 03:10, 13 August 2015 (UTC)
Nothing to apologise for! I'm actually hoping that interested parties can help take the Policy forward.
The link you made was in Talk:Taiwan#Pagebanner --Andrewssi2 (talk) 03:17, 13 August 2015 (UTC)

UnionvilleEdit

In Golden Horseshoe, I see Unionville (Ontario) has been moved out of the main listings into "Go next". I disagree with this edit on the grounds that Unionville is in Markham, a municipality adjacent to Toronto and part of the Golden Horseshoe. A "go next" destination should be outside the coverage area of the current article, albeit reachable easily enough that the voyager would be likely to visit both on the same trip. K7L (talk) 05:56, 26 August 2015 (UTC)

Please go ahead and make whatever change you think is necessary. A new user created the Unionville article and I was just trying to clean up. I don't think there is much precedent for listing a city as a "See" listing, and since it was listed as a place to go "for a day out" I moved it to "Go next". -- Ryan • (talk) • 06:08, 26 August 2015 (UTC)

IranEdit

Hi. Why have you undone my edit?

I know warnings should not be placed at the top of the guide, but it's a real exceptional case.

As I explained on the talk page, I was almost killed in Iran because of my sexual orientation.

And it definitely might happen to more homosexuals tourists.

The warning in the 'stay safe' section is certainly not enough prominent.

In this case, the warning should be much more clear.

It's a matter of life and death, and I'm not exaggerating.

Please redo my edit.

Thanks in advance, --63.141.217.81 18:33, 5 September 2015 (UTC)

Please see Talk:Iran#I've added a warning for gay/lesbian couples at the top of this guide. -- Ryan • (talk) • 18:34, 5 September 2015 (UTC)
I replied there. --63.141.217.81 18:58, 5 September 2015 (UTC)

Pagebanner dropdown menuEdit

Hi Ryan, I've got some issue when I was trying to apply the new CSS to an existing page on it:voy.

I've assumed that ".wpb-banner-toc" should be equal to ".topbanner-toc>div", but nothwithstanding this, I wasn't able to replicate the effect. I've made the test whil the old pagebanner JS/CSS was running. Do you think that it conflicts or maybe I've just applied it in a wrong way?

Thanks for any help/suggestion. --Andyrom75 (talk) 22:14, 13 September 2015 (UTC)

According to it:Speciale:Versione the WikidataPageBanner extension isn't installed on Italian Wikivoyage. You'll need to get the extension installed if you want the TOC HTML to be generated in a way that will allow for cascading drop-downs; without the banner extension there is no easy way to style the TOC to allow for drop-downs. -- Ryan • (talk) • 22:23, 13 September 2015 (UTC)
Update: I took a closer look at the TOC without the page banner extension, and the version generated when the page banner extension is in use, and the HTML structure does not seem to be different (as I thought it was), so it might still be possible to get the same effect using the old banner template. That said, the easiest way to implement this functionality is still to install the extension and test things out on a limited number of pages, and then once you are happy with the implementation you can update your pagebanner template so that the extension is used sitewide. -- Ryan • (talk) • 23:48, 13 September 2015 (UTC)
Actually, what I'm trying to do is to implement the dropdown menu without the extention. I've already patch it to fix the old issue on mobile visualization, but with the menu I'vm facing some problem, maybe due to the fact that it use CSS features that I'm not skilled with.
I feel that it should be possible and easy, however I'm not making any progress. If you have suggestions it would be great. --Andyrom75 (talk) 07:03, 14 September 2015 (UTC)
Kind reminder, just in case you would have any good idea to put in place. Thanks, --Andyrom75 (talk) 06:16, 22 September 2015 (UTC)
Sorry, I'm traveling a lot for work right now. Honestly, my recommendation would be to install the extension rather than trying to reverse engineer it since that seems the simplest solution and there is no downside to having the extension installed. -- Ryan • (talk) • 13:49, 22 September 2015 (UTC)

My editingEdit

Is it any better now? I have verfied my listings. --Softstarrs23 (talk) 22:00, 14 September 2015 (UTC)

Talkback: Nils von Barth, Inca Trail tourEdit

Hello, Wrh2. You have new messages at Nbarth's talk page.
You can remove this notice at any time by removing the {{Talkback}} or {{Tb}} template.

Bayard (Florida)Edit

I proposed merge not simple redirect. I know not a lot to salvage but maybe at least the bar could be referenced. Just do not want to discourage contributors. --Traveler100 (talk) 16:16, 14 October 2015 (UTC)

The user who created that article was indefinitely blocked on Wikipedia and has made some problematic edits here before. Any info on that page would thus be suspect and would need to be double-checked, and since much of it was dubious (such as a listing for Dunkin' Donuts) I think a simple redirect should suffice. If you disagree please merge whatever bits you feel are worth saving. -- Ryan • (talk) • 16:21, 14 October 2015 (UTC)
OK, I did not look into the history of the user. --Traveler100 (talk) 19:20, 14 October 2015 (UTC)

Problem with BannerEdit

Hi! I'd like to import template "Banner" to Estonian Wikibooks. I imported content from Common.css, Common.js, and Template:Banner. If I look my page, there are some errors. There's no pictures (maybe because theres no needable div's?). What can I do to make it work?
Postituvi (talk) 16:02, 17 October 2015 (UTC)

The banner template is dependent on the new mw:Extension:WikidataPageBanner extension. If you don't want to install that extension you can use a version of the template from before January 2015 (and CSS/JS from before that date) and it should work for you. -- Ryan • (talk) • 22:56, 17 October 2015 (UTC)

User:YanlinnnaungEdit

Hi. I don't know if you have noticed this guy's user page. In my opinion, it's plain toutism, offending several of our policies, almost comically. I was wondering if he should be mildly warned about this.Ibaman (talk) 17:06, 4 November 2015 (UTC)

User:Ikan Kekek has already made some suggestions to the user. For my part I'm generally pretty lenient about letting people do what they want in userspace, so I may not be the best person to assist in this instance. -- Ryan • (talk) • 17:15, 4 November 2015 (UTC)
  • Hello, I'm not tout and vandalism on any page! I'm made a edition with truth information on Myanmar article! If have something wrong with me! Please give me next some suggestion? Yanlinnnaung (talk) 17:29, 4 November 2015 (UTC)
Ibaman and Ryan, I'm willing to give Yanlinnnaung some latitude. As you can tell, English is not his/her first language, and s/he has been making substantive contributions to existing articles and starting new articles about some places in Myanmar, a country that could use more coverage on this site. I think it makes perfect sense to continue to act on the basis that s/he is operating in good faith, until or unless there is very clear evidence to the contrary. You can see my remarks at User talk:Yanlinnnaung#Your user page. If you have any specific comments to add about changes that Yanlinnnaung could implement, you could add them there. Ikan Kekek (talk) 10:12, 5 November 2015 (UTC)
  • I look forward for this willing of [[User:Ikan Kekek|Ikan Kekek], and thanks for you willing to help. Yanlinnnaung (talk) 10:36, 5 November 2015 (UTC)

Thank youEdit

  The Wikivoyage Barncompass
Just wanted to offer my thanks for all the work you've done proposing the change to the region template and keeping the discussion moving at a nice pace. I've got a really good feeling about this and what it will do for Wikivoyage. In fact, I'm already eagerly planning some changes to a bunch of region pages based on your proposal! PerryPlanet (talk) 20:51, 21 November 2015 (UTC)
I second this. Thanks for the work in conceiving it and pushing it forward. I think it's a good step towards improving our guides. -Shaundd (talk) 06:24, 22 November 2015 (UTC)
The feedback is much appreciated, as is the support you have provided throughout the process of trying to implement this change. I very much expect that this change may finally drive some development on a lot of unusable region articles, and am very interested to see if that prediction proves correct. -- Ryan • (talk) • 06:57, 22 November 2015 (UTC)
Very well deserved. --Saqib (talk) 08:22, 22 November 2015 (UTC)

Listing editorEdit

DISALLOW_ADD_LISTING_IF_PRESENTEdit

Could you show me an affected page? Currently I'm in doubt if it really works (I mean if it's usefull); maybe yes but I can't figured out any example. PS I know that the equivalen code existed also in the past, but I've got the same doubt at that time. Thanks, --Andyrom75 (talk) 12:28, 27 November 2015 (UTC)

You can click on any article in Category:Region articles or Category:Country articles and the "add listing" link is disabled for all sections because the DISALLOW_ADD_LISTING_IF_PRESENT pattern matches. -- Ryan • (talk) • 16:30, 27 November 2015 (UTC)
Got it (thanks). I've choosen Achill Island and I see that although the eat listing works, is missing the [add element] link. Which is the reason behind this choice? To push for prose text in country & region articles? --Andyrom75 (talk) 16:58, 27 November 2015 (UTC)
Yes, since individual business listings should not generally be added to country or region articles this pattern prevents the listing editor from encouraging editors to add listings to those types of articles.
As a side note, if you are interested in using the current envoy listing editor on Italian Wikivoyage, I have attempted to port the English version to match the Italian version at User:Wrh2/Gadget-ListingEditor-it.js. It is untested, but should include most of the customizations needed to match what is currently in use on Italian Wikivoyage. -- Ryan • (talk) • 05:37, 28 November 2015 (UTC)
Thanks for the clarification; it makes sense. And thanks a lot for your customization page. In this days (maybe as you have noticed) I'm working to upgrade our script to get some of the nice benefit that you have added with your excellent job. This should speed up the upgrade. I hope to not disturb you further, but I'll make you a whistle in case of need :-P --Andyrom75 (talk) 08:25, 28 November 2015 (UTC)
You have added this comment "// TODO - IT needs to modify the listing template to add a span that will contain the edit link". We already have the "span.listing-metadata-items"-elements. Are you maybe referring to something else? Please let me know. PS Instead of a mere integrally copy & paste, I'm doing a longer step to step approach, trying to understand better the script and to avoid to disturb you in the future for any minor doubt or change that we may need. --Andyrom75 (talk) 10:34, 28 November 2015 (UTC)
Regarding the TODO, that note was there because we changed the base listing template on envoy, and other language versions will need to do so as well to work with the latest code. If your template already has a span that contains then edit link then you can ignore that note. -- Ryan • (talk) • 16:16, 28 November 2015 (UTC)
Ok. I've just thought that it was a note specifically for it:voy.
One question on the new function findSectionIndex that has substitute the old findSectionNumber. Why it has been removed if (link === undefined) link = entry.closest('div.mw-h2section').find( '.mw-editsection a' ).attr( 'href' );? It was unnecessary? PS The associated comment was "// if no subsection match found, look for the nearest major section". --Andyrom75 (talk) 18:19, 28 November 2015 (UTC)
The old "findSectionNumber" was split up - "findSectionHeading" gets the count of the section being edited, and "findSectionIndex" examines the "edit" link to get the section index. It's been a while since I worked on this code so I don't remember specifically why that portion of the code was changed, but one thing I was trying to do in the cleanup was to make the code rely less on pattern matching (since pattern matching was breaking in a lot of corner cases) and instead on indexes and counts that would be more consistent. -- Ryan • (talk) • 05:46, 29 November 2015 (UTC)

Minor fixesEdit

On js: "ALLOW_UNRECOGNIZED_PARAMETERS: LISTING_CONTENT_PARAMETER" must be changed to "ALLOW_UNRECOGNIZED_PARAMETERS: ALLOW_UNRECOGNIZED_PARAMETERS"

On css: 0em, 0px, 0% can be changed to 0, to remove the relevant "minor warning". --Andyrom75 (talk) 09:20, 28 November 2015 (UTC)

On js: I suppose that your intent was to list the exposed public members in the same order of their declarations. In the affirmative case, you may want to postpone EDIT_LINK_CONTAINER_SELECTOR right after LISTING_CONTENT_PARAMETER. Clearly it has no effect in the code. --Andyrom75 (talk) 10:40, 28 November 2015 (UTC)
On js: For consistency with the rest of exposed public members, could be a good idea to change "init: initListingEditor" to "initListingEditor: initListingEditor" or maybe there's a best practice that suggest to always call the constructor as "init"? --Andyrom75 (talk) 15:06, 28 November 2015 (UTC)
Thanks for the feedback - I fixed ALLOW_UNRECOGNIZED_PARAMETERS (Special:Diff/2846914/2896712), although I'll need to revisit that code when I have more time since for some reason it's been working fine even with the bug. I also resolved the CSS warnings (Special:Diff/2835372/2896715). I cleaned up the code by exposing the EDIT_LINK_CONTAINER_SELECTOR value in the same order that it is declared (Special:Diff/2896712/2896716). For now I've left "init" alone since it's common practice to initialize a Javascript object with a name like "init" or "initialize", and it's also fairly common practice to use more descriptive names internally within the object, but if you think it's causing confusion I'm happy to make a change. -- Ryan • (talk) • 16:30, 28 November 2015 (UTC)
What about making the opposite change: "init: initListingEditor" to "init: init"? However it's not a big deal; it's just to be consistent with the rest of the variables.
Another thing. I would change RegExp('{{\\s*(' + regex.join('|') + ')\\b','g'); into RegExp('{{\\s*(' + regex.join('|') + ')\\s*\\|','g'); to be sure to not match templates that starts with the same letters. This is something that I've previously patched in it:voy. I've noticed that you patched the older version adding "\\b" but consider that a template may have a space, so the only way to match only the desired templates is to catch also the pipe (i.e. "|") PS Note that in this way the regex won't match for example {{see}}, but it's not a real case (a listing without any paramenter doesn't make any sense to exist). --Andyrom75 (talk) 17:40, 28 November 2015 (UTC)
Indentation on addEditButtons should be fixed removing 1 tab from the comment "// if there is already metadata present add a separator". --Andyrom75 (talk) 00:18, 29 November 2015 (UTC)
Thanks - I've fixed the indentation and will investigate the regex change. -- Ryan • (talk) • 06:01, 29 November 2015 (UTC)
Errata corrige: Looking in the history, I've noticied that triginally I've substituted var listingRegex = new RegExp("{{\\s*(" + regex.join('|') + ')','g'); and not your patched version with "\\b". In the old code "\\b" is equivalent to "\\s*\\|", and it was used only in one place, but in the new code, this regex is used in two places, and in one of the two (according to the current code) works only "\\b", so keep it as it is, to avoid useless rework.
What about the init? --Andyrom75 (talk) 08:26, 29 November 2015 (UTC)
A minor change that I have applied on it:voy is this one, because is grammatically wrong to use two columns in sequence (at least in Italian grammar). So the summary will be: "action: listing name - summary". --Andyrom75 (talk) 12:41, 29 November 2015 (UTC)
I've applied the change to the edit summary: Special:Diff/2896943/2897166. -- Ryan • (talk) • 17:15, 29 November 2015 (UTC)

<p> patchEdit

I would remove the code associated to this patch because it shouldn't be no longer needed since the [edit] link is shown properly, thanks to another patch. Furthermore it cause problems when in the content is present a bulleted/numbvered list.

The code to remove is:

			if (listingTemplateAsMap[ListingEditor.Config.LISTING_CONTENT_PARAMETER]) {
				// convert paragraph tags to newlines so that the content is more
				// readable in the editor window
				listingTemplateAsMap[ListingEditor.Config.LISTING_CONTENT_PARAMETER] = listingTemplateAsMap[ListingEditor.Config.LISTING_CONTENT_PARAMETER].replace(/\s*<p>\s*/g, '\n\n');
			}

and

			// newlines in listing content won't render properly in lists, so
			// replace them with <p> tags
			$('#input-content').val($.trim($('#input-content').val()).replace(/\n+/g, '<p>'));

--Andyrom75 (talk) 08:49, 29 November 2015 (UTC)

The issue being addressed by the above code isn't for rendering "edit" links, it is for ensuring that multi-paragraph listing content will use <p> tags instead of newlines (see also MediaWiki talk:Gadget-ListingEditor.js#Multiline content listings for past discussions on a related issue). Removing the above code would result in listings that contain newlines instead of <p> tags, which Mediawiki will interpret as new paragraphs, forcing it to close the current list item and paragraph and resulting in an improperly-formatted listing. For an example of what the listing looks like when it uses <p> tags properly see the "Maltese Cross Cabin" listing in Theodore Roosevelt National Park#See. -- Ryan • (talk) • 17:00, 29 November 2015 (UTC)
Not all the user are familiar with HTML, so in my opinion it's not a good idea to introduce it this way (I'm thinking to those who will edit the wikicode in the standard way). There's no transparent workaround, maybe playing with CSS/XML? In the negative case, do you think that this behaviour can be patched on the WM-parser? PS As said above, it preclude the possibility to have lists inside. Currently I must exclude it on it:voy, it's important to try to find another solution. --Andyrom75 (talk) 18:04, 29 November 2015 (UTC)
Using a <p> tag is the solution recommended by Mediawiki - mw:Help:Lists#Paragraphs in lists - so I'm going to leave that as-is for the envoy listing editor. If different language versions choose different solutions that should be fine. -- Ryan • (talk) • 18:32, 29 November 2015 (UTC)
Sure, no problem for the different implementation (it's more than normal :-P), but the very bad thing is that if this is a recommended solution it means that the chance of a patch server side would be very low. Thanks for the link. --Andyrom75 (talk) 18:57, 29 November 2015 (UTC)

No heading bugEdit

I've just noticed a bug on the current implementation, but I haven't studied a remedy.

If you have a page (tipically a test page) without any heading, the listing editor always show the first listing of the page. I think that it's enough to init properly a count variable to solve the issue.

Look at this page to see what I've explained. PS Since is not the last version, the edit links are not shown. --Andyrom75 (talk) 09:45, 29 November 2015 (UTC)

Nested listing bugEdit

There's another bug more urgent to solve. See my sandbox. This is a simple example where is possible to see that also the visualization in the form is wrong, but in it:voy I've found another case where the visualization is correct, but when you save it, it delete both the listing and the above part of the container template. Any quick idea? --Andyrom75 (talk) 18:17, 29 November 2015 (UTC)

After few test I think I've understood that the problem is in getListingWikitextBraces function. Please check it to see if it's easy for you to fix it. --Andyrom75 (talk) 22:12, 29 November 2015 (UTC)
Does Italian Wikivoyage allow nested listings? I can't think of any scenario where that would be done on English Wikivoyage. -- Ryan • (talk) • 22:13, 29 November 2015 (UTC)
As said above, please see both pages: my sandbox in en:voy and article in it:voy. The patch for the it:voy case is quite urgent because it destroy the wikicode. --Andyrom75 (talk) 07:20, 30 November 2015 (UTC)
I've looked at the test pages, but my question is whether real articles on Italian Wikivoyage allow nested listings. On English Wikivoyage I can't think of any case where that would be done, so I'm not sure that this is a bug that anyone would ever encounter in an actual article. -- Ryan • (talk) • 15:22, 30 November 2015 (UTC)
Maybe you miss the link to it:voy that I've put above. Now in bold should be more visible. --Andyrom75 (talk) 20:33, 30 November 2015 (UTC)
Please confirm hat you saw the code that is in use on it:voy. I need urgently you support on this patch becuase the current implementation is quite dangerous in such cases. Thanks in advance. --Andyrom75 (talk) 07:29, 1 December 2015 (UTC)
I haven't had a chance to investigate yet. If the issue is urgent I'd recommend reverting recent listing editor changes for now as I'm not sure I'll get to it for a few days, and since it's an odd use case I'm guessing it might be difficult to fix. I'll let you know if I figure something out. -- Ryan • (talk) • 15:29, 1 December 2015 (UTC)
Gosh, I'm sorry to read it, because I counted on your precious support. I'll try to see a way to disable or fix this case. Any input from your side will be highly appreciated. --Andyrom75 (talk) 19:13, 1 December 2015 (UTC)
@Andyrom75: I still need to do a LOT of testing, but Special:Diff/2898378/2898385 fixes the issue in my local sandbox (User:Wrh2/Sandbox). It's very possible that this change may have unexpected side-effects, so if you do decide to deploy it on Italian Wikivoyage be very careful. I probably won't push it on English Wikivoyage until I've spent at least a few days testing it out. -- Ryan • (talk) • 01:58, 2 December 2015 (UTC)
I'm going to test it and I'll let you know. Thanks a lot for your support! --Andyrom75 (talk) 07:01, 2 December 2015 (UTC)

All the tests I've done in the it:voy page I've mentioned:

  • Modify the first nested listing in a template
  • Modify an intermediate nested listing in a template
  • Modify the last nested listing in a template
  • Delete an intermediate nested listing in a template
  • Modify a nested listing within a template different from the previous one
  • Modify regular listing

have ended successfully (many thanks Ryan!), so I've deployed the patch in it:voy. I don't know if I've tested all the cases, but for sure I've mitigated the biggest problem, so although could be a risk to have introduced an unexpected issue, for sure will be minor from the previous one. By the way I'll keep on testing and tracking all the next listing uses.

During the tests I've noticed a strange behaviour that is independent from the patch. I've noticed that a couple of "standard" listing that I've created in my test page (test2, test4 and test5 .... but not test7) are wrongly saved. Practically are saved as they would be inline listing. This clearly is not urgent like the previous one, but if you could take a look on you spare time would be good. In the meanwhile I'll try to see if it would occur here as well (I suppose because it doesn't seem to be related to any it:voy customization). Thanks again, --Andyrom75 (talk) 08:28, 2 December 2015 (UTC)

I've just noticed that the issue is on isInline function that return the wrong status. Furthermore is should contemplate the case of nested listing to apply the proper format. In this second case I think that can just be check that the previous char sequence would be "=\s*"; what do you think? --Andyrom75 (talk) 12:39, 2 December 2015 (UTC)
I encountered an issue yesterday where editing a multi-paragraph listing that uses newlines instead of <p> tags results in the listing being treated as inline the first time it is edited (since Mediawiki breaks the HTML list due to the newlines), but it works the second time the listing is edited since the listing editor now replaces newlines with paragraph tags. Is that what you are seeing? Your suggested fix of identifying inline listings by checking for a list character prior to the listing wiki syntax might be a good workaround, although it will be insufficient for cases like the embassy listings with flags preceding them in San Francisco#Cope, so further investigation would be needed. -- Ryan • (talk) • 15:52, 2 December 2015 (UTC)
All the test2, test4, test5 and test7 are multiline without <p>, but test7 is managed correctly by the current script (the content are practically the same). However, consider that the old script managed correctly all the multiline cases, but I can't judge if the problem is on the isInline function or elsewhere in the new script logic.
When I say to apply the "=\s*" check, I meant to do it as an alternative case to the current one: "if A or B then", so, if I'm not wrong, the embassy case will be still managed by the current logic, because is in a dotted list. Is it correct? --Andyrom75 (talk) 18:53, 2 December 2015 (UTC)
I don't know if you have evaluate the above idea, however in the meanwhile I would ask another thing. Do I have to apply this change? I'm referring to "+1". --Andyrom75 (talk) 19:21, 3 December 2015 (UTC)
The current version of MediaWiki:Gadget-ListingEditor2.js (including the "j+1") is what I've been testing with. Without the diff you cited it was adding listings with a missing closing brace in my testing. -- Ryan • (talk) • 19:24, 3 December 2015 (UTC)
I've got that doubt because in the previous diff that you suggested this wasn't included. Thanks for clarify it. By the way I've just noticed that the right diff link I was referring is this one.
What about the "if A or B then" discussed above? --Andyrom75 (talk) 23:22, 3 December 2015 (UTC)
Regarding the diff you linked, that removes some code that I don't think is needed (I commented it out previously) - if I'm understanding correctly, it checks for braces in code that we've already matched using a regex and know has just two opening braces. The last bit (the "j+1") is just ensuring that if the listing is the last thing on a page we don't generate an array out of bounds exception by trying to get a substring that exceeds the article content length.
I need to follow-up on the inline listing issues as well as several other issues from the threads above. My day job involves writing code for 8-10 hours, so if any of these issues are critical let me know, otherwise I'll get to them when the idea of debugging code for free after a long day of debugging code for work seems more appealing :) -- Ryan • (talk) • 23:36, 3 December 2015 (UTC)
The test I've performed last time was without the "j+1", but considering that you have added in your last edit I was in doubt to add it (for some reason) and if you think, to test it again. Otherwise I'll let the current code.
The above patches are not critical as the original one that distroyed the code. So check it only when "debugging code for free seems more appealing" (too funny :-DDD)
By the way, you don't know how many people do not understand why I am (we are) doing all this stuff for free, and more I explain and more the expression in their face become stranger and stranger. You cannot explain the beauty of a picture, sculpture, panorama, etc.; you just feel it or not... ;-)
Let me thank you again for all your precious support. --Andyrom75 (talk) 08:20, 4 December 2015 (UTC)

@Andyrom75: I made a slight change to isInline() that seems to resolve the issues in my local testing by verifying that the listing hasn't been split by the Mediawiki parser due to multiline content. Let me know if you have any issues with this change:

	var isInline = function(entry) {
		// if the edit link clicked is within an HTML list then it is not
		// inline. additionally, since newlines in a listing description
		// will cause the Mediawiki parser to close an HTML list (thus
		//  making the "is edit link within a list" test fail), also verify
		// that the listing is within the expected span tag and thus hasn't
		// been incorrectly split due to newlines.
		return (entry.closest('ul, dl, ol').length === 0 && entry.closest('span.vcard').length !== 0);
	};
I've tried the above patch but I haven't seen any improvement both on it:Utente:Andyrom75/Test (where there are multilines listings) and on it:Lago d'Iseo#Cosa vedere (where there are nested listings into a template). On the other end I've seen the result of your test here in your Sandbox and it seems to work. Mayber there's an issue somewhere but I don't see where. I apply your patch and then compare again the script. --Andyrom75 (talk) 21:49, 5 December 2015 (UTC)
I've aligned it:MediaWiki:Gadget-ListingEditor.js to MediaWiki:Gadget-ListingEditor2.js (excluding lastedit and "P" code; and also the IT custom code on updateSectionTextWithAddedListing). The only change was on the "J+1" code. Currently the multilines on test page work but the nested listings on the article don't and if I'm not wrong the code is ruined on saving. Try the see listing numer 3 or 4. --Andyrom75 (talk) 23:22, 5 December 2015 (UTC)
Looking at this diff, While the listing is reformatted, it doesn't appear that any content is lost in - is that the link you were referring to as "listing number 4"? Maybe the correct solution is to just change the meaning of "isInline" to be a listing that is within a paragraph? Right now the rule is that it tries to treat listings that aren't within a list as inline, but your nested listing examples aren't within a list and are thus treated as inline, which isn't what you want it to do - is that right? -- Ryan • (talk) • 02:36, 6 December 2015 (UTC)
You got exactly the point. The isinline function should check if the listing is or not within a paragraph. I don't know if what I said above with checking if there's an equal sign before the listing template (i.e. "=\s*") could be a good idea or if there is a better one. Basically when I'm using an inline listing I'm just inserting a "formatted sentence" into a text, so the inline structure is more comfortable for being edited. While, if I'm in the middle of a dotted/numbered list or inside a more complex template, the "not inline" structure is more readable and better editable.
Regarding the content you are right, nothing is lost, however during my test I experienced a strange thing. I'm used to substitute the whole content of saveForm function with just "alert( sectionText );" and what I see on the popup window is that some part of the sectionText is missing, but using "consoleLog( sctionText );" I can effectively verify that everything is fine. --Andyrom75 (talk) 08:19, 6 December 2015 (UTC)
Special:Diff/2900300/2900898 changes "isInline" to just check to see if the listing is within a paragraph. I haven't tested it heavily, but so far this new code seems to perform as you've requested. -- Ryan • (talk) • 05:16, 7 December 2015 (UTC)
Awesome! Also the test I've made ended successfully. I've just implemented to see if during the use will arise any unexpected behaviour. Thanks again a lot! --Andyrom75 (talk) 08:16, 7 December 2015 (UTC)

Landing pageEdit

When is modified and saved a listing starting from the "last diff address", the landing page is the same diff, and it's quite annoying becuase to see the effect of the change must be load the page (without any specific diff). Do you think is possible to adjust this behaviour?

PS modifying a paragraph in the regular way, starting from the "last diff address", do not have this issue becuase when you click on edit it reload the page without any diff in the URL, but being the listing editor, a JS popup window, this won't happen. --Andyrom75 (talk) 12:26, 8 December 2015 (UTC)

I've noticed that before but haven't investigated whether a fix is easy to do or not. I've added the issue to Wikivoyage:Listing editor#Bugs and feedback. -- Ryan • (talk) • 15:40, 8 December 2015 (UTC)

needs improvementEdit

this tag is a good idea could i use it in my edits Ryan? I know you think iam a pcv and i know i have deminstrated this behavior in the past but iam trying to work with you people. --DonLandry2 (talk) 18:16, 2 December 2015 (UTC) I'am not a vandal stop deleting my stuff --DonLandry2 (talk) 18:54, 2 December 2015 (UTC)

Deleted entrancesEdit

Hello, some of my entrances has been deleted, and even if you may think that it looked like a promotional use, i have to say that i was just adding information. I mean, every article that i have edited has at least one similar entrance, and i think it´s not fair for the travelers that you only show a few options, and always the same. Please un-delete my entrances. Kindly, Alex.

Page bannerEdit

Hi,

The page banner extension has been activated on french Wikivoyage but I have some problems to write the new template script. The template is here and my first tests here. Let me know if you can help. --Adehertogh (talk) 17:02, 8 December 2015 (UTC)

I should have time to take a look after work tonight, but if I forget please leave me a reminder note on this talk page. -- Ryan • (talk) • 17:14, 8 December 2015 (UTC)
I added a page banner to my sandbox at fr:Utilisateur:Wrh2/Sandbox that seems to work. I used the following to do so:
The flag image was tricky since it can no longer be included as part of the page name - my solution was to use Javascript, although this may not be a great option and you might considering pinging User:Jdlrobson to request an update to the banner extension to support icons next to the page title. Hope that helps! -- Ryan • (talk) • 02:02, 9 December 2015 (UTC)
Please do raise a bug/feature request if there is some functionality missing! You can login with your Wikivoyage account! Jdlrobson (talk) 17:13, 9 December 2015 (UTC)
Thanks, but unfortunatly I still see two problems (which were my main problems before I ask your help):
  1. The isin navigation bar is under the banner.
  2. The map icon (from geo template) is on the right of the subtitles line (I added an infobox on your sandbox to illustrate this problem).
Any idea? --Adehertogh (talk) 10:23, 9 December 2015 (UTC)
Have a look at fr:Utilisateur:Wrh2/Sandbox now and let me know if that works for you.
  1. There is an open ticket (phabricator:T113642) about the breadcrumb navigation. Personally I think having it under the banner is the correct behavior since the page title should be the first thing on the page, but a Javascript workaround is in place to move it back to the top for now.
  2. The French map icon is larger than the English version since it includes coordinates, so I had to tweak the workaround used on English Wikivoyage. Hopefully that works for you.
Let me know if there are any other issues. -- Ryan • (talk) • 15:31, 9 December 2015 (UTC)
Hi, the isin navigation bar works well (good job) but I tried the map icon with coordinates on several browser/systems and it seems to work on explorer on windonws (great) but doesn't on Firefox or Safari on Mac OS (it doesn't display). Why? I also had the labels like UNESCO and a few others. It works but one of them: Un des plus beaux bourgs d'Italie doesn't.--Adehertogh (talk) 16:47, 12 December 2015 (UTC)
For icons, see the instructions at mw:Extension:WikidataPageBanner - you will need to add a CSS style for each icon image such as:
.oo-ui-icon-unesco {
    background-image: url('https://upload.wikimedia.org/wikipedia/commons/b/b1/WorldHeritageBlanc.svg');
}
Regarding the map icon, fr:Utilisateur:Wrh2/Bannière page looks fine for me using Chrome and Firefox on Windows. Are you certain that you've copied all of the CSS & JS from fr:Utilisateur:Wrh2/common.js and fr:Utilisateur:Wrh2/common.css? If so, can you give me an example page that I could look at to try to reproduce the problem? -- Ryan • (talk) • 18:06, 13 December 2015 (UTC)
Icons are working well except one: Un des plus beaux bourgs d'Italie
.oo-ui-icon-villageitalie {
    background-image: url('https://upload.wikimedia.org/wikivoyage/fr/6/62/I_borghi_pi%C3%B9_belli_d'Italia.PNG');
}
On this file: fr:File:Fichier:Capture écran pour bannière.tiff you can see your sandbox on Firefox/Mac OS. I add some labels 1. UNESCO, 2. Un des plus beaux bourgs d'Italie (black gap), 3. Un des plus beau village de Wallonie, 4. Star article, 5. Disambiguation to illustrate the icon problem. --Adehertogh (talk) 20:52, 14 December 2015 (UTC)
I've updated fr:Utilisateur:Wrh2/common.css with CSS for a few of the icons - hopefully that helps? If not let me know what else I can assist with. -- Ryan • (talk) • 04:22, 15 December 2015 (UTC)
Everthing was working fine so I implement the new template on the wiki but... then I found that the template read the apostrophe in the title as a code exemple: Parc_national_d'Iguazú. --Adehertogh (talk) 18:13, 16 December 2015 (UTC)
I made a slight modification to fr:Modèle:Bannière page, and fr:Parc national d'Iguazú now shows up correctly when I view it. Let me know if you encounter any other issues. -- Ryan • (talk) • 02:19, 17 December 2015 (UTC)
The geo icon doesn't appear on the top right corner of the screen when there is a banner. A second issue had been reported that the TOC sometimes appear "normaly" (outside the banner) but it seems to be temporaly till the user's computer reload the all code of the new template. --Adehertogh (talk) 10:12, 20 December 2015 (UTC)
If I look at fr:Paris I see an icon & coordinates in the top right (using Chrome) - the div has an ID "geoCoord". Is something else supposed to be there, or is it supposed to go in a different location? As to the TOC sometimes appearing normally, that's another bug that they are working to fix, but so far the cause is undetermined. For now you can work around it by making a minor edit to fr:Modèle:Bannière page, which will then cause all pages with banners to be re-cached. -- Ryan • (talk) • 06:37, 22 December 2015 (UTC)

False positives?Edit

Hi Wrh2. Regarding the big 23,120 items list I have generated - I am still not exactly sure what you and Traveler100 meant in the Travellers' pub discussion page when you both mentioned that it has "too many false positives". Please explain exactly what type of articles you noticed in that list that were not supposed to be in it.

  • Did you mean that some of the items in the list were only Engvoy redirect pages instead of actual articles with corresponding articles on Wikipedia?
  • Did you mean that some of the items in the list, which do have corresponding articles on Wikipedia, already have a link on the Wikipedia page which sends their reads to the corresponding Engvoy article? (there should be around ~3,000 of those, which are only a small portion from the total 23,120 articles which need links back from Wikipedia).
  • Or maybe you meant something else?

Please be specific so that I can address the problem and try to remove as many items as I can which aren't supposed to be there. ויקיג'אנקי (talk) 20:21, 15 December 2015 (UTC)

A "false positive" is a report that a Wikipedia article is missing a link to Wikivoyage when it isn't. I'm not concerned about the number of false positives in the current list since it's simple to check the Wikipedia article and remove items that already have links, although it would be problematic if those entries were included again if the list was regenerated. -- Ryan • (talk) • 20:30, 15 December 2015 (UTC)
Oh okay. In that case, again, it is not a big problem since there should only be around ~3,000 of those (the instances in which the name of the article on Engvoy isn't identical to the name of the article on the English Wikipedia), which are only a small portion from the total 23,120 articles on the list. ויקיג'אנקי (talk) 20:44, 15 December 2015 (UTC)
Please let me know if you come across other types of articles which I could try to identify and remove from the big list as well (for example, too many redirect, etc). ויקיג'אנקי (talk) 20:45, 15 December 2015 (UTC)

Re: Listing editorEdit

Hello, Wrh2. You have new messages at Peter Chastain's talk page.
Message added 09:41, 27 December 2015 (UTC). You can remove this notice at any time by removing the {{Talkback}} or {{Tb}} template.
Return to the user page of "Wrh2/Archive 2015".